-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kube-rbac-proxy version bump #2744
Conversation
✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/arvin/kube-rbac-proxy-0.18.1 |
Pull Request Test Coverage Report for Build 11440467508Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
db417a1
to
12c6a31
Compare
12c6a31
to
5a14283
Compare
@mhrabovcin There seems to be no visible effect or improvement after the update. If you've got any suggestions or alternate steps we could try, I'd appreciate your input. |
@ArvinderPal09 the You need to bump it in the dex configmap overrides with the right nesting so that value gets picked up - https://github.com/mesosphere/kommander-applications/blob/main/services/dex/2.14.0/defaults/cm.yaml#L105-L117 |
0972885
to
5a14283
Compare
9290319
to
649873a
Compare
What problem does this PR solve?:
Bumps kube-rbac-proxy version to 0.18.1
Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-102774
Special notes for your reviewer: