Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: kube-rbac-proxy version bump #2744

Merged
merged 9 commits into from
Oct 21, 2024
Merged

Conversation

ArvinderPal09
Copy link
Contributor

What problem does this PR solve?:
Bumps kube-rbac-proxy version to 0.18.1

Which issue(s) does this PR fix?:
https://jira.nutanix.com/browse/NCN-102774

Special notes for your reviewer:

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. services/kube-prometheus-stack labels Oct 16, 2024
@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Oct 16, 2024
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/arvin/kube-rbac-proxy-0.18.1

@coveralls
Copy link

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11440467508

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 11389976596: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. services/dex and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 16, 2024
@ArvinderPal09 ArvinderPal09 self-assigned this Oct 16, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2024
@ArvinderPal09 ArvinderPal09 added ok-to-test Signals mergebot that CI checks are ready to be kicked off and removed ok-to-test Signals mergebot that CI checks are ready to be kicked off labels Oct 16, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2024
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 17, 2024
@ArvinderPal09
Copy link
Contributor Author

@mhrabovcin
I tried bumping the kube-rbac-proxy version in the two files ( services/dex/2.13.14/dex.yaml
/services/kube-prometheus-stack/60.4.1/helmrelease/kube-prometheus-stack.yaml) but unfortunately didn't have any success with it.
This is the reference link for rbac-proxy : https://github.com/prometheus-community/helm-charts/blob/848f830e5dabb8027e42e090ba94e05e5f1b6c75/charts/kube-state-metrics/values.yaml#L106

There seems to be no visible effect or improvement after the update. If you've got any suggestions or alternate steps we could try, I'd appreciate your input.

@mhrabovcin
Copy link
Contributor

@ArvinderPal09 the dex kube-rbac-proxy comes from the bundled dex-controller chart - https://github.com/mesosphere/dex-controller/blob/master/charts/dex-controller/values.yaml#L21-L26

You need to bump it in the dex configmap overrides with the right nesting so that value gets picked up - https://github.com/mesosphere/kommander-applications/blob/main/services/dex/2.14.0/defaults/cm.yaml#L105-L117

@mhrabovcin mhrabovcin added open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Oct 21, 2024
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. services/logging-operator services/centralized-grafana services/traefik services/grafana-logging services/cert-manager services/centralized-kubecost services/karma services/knative services/kubecost services/project-grafana-logging services/kommander-ui and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 21, 2024
@mhrabovcin mhrabovcin merged commit b6b4be6 into main Oct 21, 2024
108 checks passed
@mhrabovcin mhrabovcin deleted the arvin/kube-rbac-proxy-0.18.1 branch October 21, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/centralized-grafana services/centralized-kubecost services/cert-manager services/dex services/grafana-logging services/karma services/knative services/kommander-ui services/kube-prometheus-stack services/kubecost services/logging-operator services/project-grafana-logging services/traefik size/S Denotes a PR that changes 10-29 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants